Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the match is loaded when checking for initial dynamic filter responses #991

Merged
merged 1 commit into from
May 13, 2022

Conversation

KingOfSquares
Copy link
Contributor

The old implementation would query the filters at register time, but if some filter was looking for a match time object which was not yet loaded and therefore abstained it would throw an error during register. (e.g GoalFilter)

The new implementation postpones the initial dispatch of dynamic filter responses until the match is done loading to make sure the context is fully loaded.
Signed-off-by: KingSimon 19822231+KingOfSquares@users.noreply.github.com

…r responses

Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
@Pablete1234 Pablete1234 added the ready PR is ready to merge label May 12, 2022
@Electroid Electroid merged commit 13b0a94 into PGMDev:dev May 13, 2022
@KingOfSquares KingOfSquares deleted the initial-dynamic branch May 19, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

3 participants