Make sure the match is loaded when checking for initial dynamic filter responses #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r responses Signed-off-by: KingSimon <19822231+KingOfSquares@users.noreply.github.com>
Pablete1234
approved these changes
May 12, 2022
Electroid
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation would query the filters at register time, but if some filter was looking for a match time object which was not yet loaded and therefore abstained it would throw an error during register. (e.g GoalFilter)
The new implementation postpones the initial dispatch of dynamic filter responses until the match is done loading to make sure the context is fully loaded.
Signed-off-by: KingSimon 19822231+KingOfSquares@users.noreply.github.com