Add wordmark component dan #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szeckirjr
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Added component for wordmark that can be adjusted for size, color, accessibility - brain dump from Mike and HC-IPPM/safe-inputs#109, still need a full test coverage and code clean up * added wordmark component (Canada logo) from Mike's brain dump - still working on tests for colour * Add wordmark component dan (#26) * Change Wordmar attribute API * Added tests for color,monochrome variants * Add test section comment * Fix broken test: wrong Wordmark variant invoked * removed maxWidth as not a svg attribute (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute), removed unused roles from flag and text color * removed static canada.svg file --------- Co-authored-by: Daniel Lauzon <daniel.lauzon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the flagColor attribute to variant="color"|"monochrome"
so now it is not possible to have black text with white flag.
Also added tests for checking that the color makes it into the SVG (this might be too tied to the implementation, but I had no better idea.
Lastly it has an example of "data driven" tests; i.e. same test done with different parameters:
monochrome variant implies flagColor==textColorand do the test with'white', then'black'