Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGI C++ compiling/test passing #543

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

PGI C++ compiling/test passing #543

wants to merge 1 commit into from

Conversation

PhilipDeegan
Copy link
Member

No description provided.

@PhilipDeegan
Copy link
Member Author

PhilipDeegan commented Apr 29, 2021 •
edited
Loading

gtest define macro causes issues

google/googletest#3390

sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h

edit: resolved by cmake refactor, declare CXX_STANDARD after deps

@PhilipDeegan
Copy link
Member Author

highfive cmake config issue with PGI BlueBrain/HighFive#446

nicolasaunai
nicolasaunai reviewed Apr 30, 2021
View reviewed changes
src/amr/tagging/tagger.h Outdated Show resolved Hide resolved
res/cmake/dep/highfive.cmake Outdated Show resolved Hide resolved
src/core/data/grid/gridlayout.h Outdated Show resolved Hide resolved
src/core/data/ions/particle_initializers/maxwellian_particle_initializer.h Outdated Show resolved Hide resolved
src/core/data/particles/particle_packer.h Outdated Show resolved Hide resolved
src/diagnostic/detail/types/particle.h Outdated Show resolved Hide resolved
@PhilipDeegan
Copy link
Member Author

build passing on TC https://hephaistos.lpp.polytechnique.fr/teamcity/buildConfiguration/Phare_Phare_GhPrPgccSamraisub

@PhilipDeegan PhilipDeegan removed the WIP work in progress label May 5, 2021
@nicolasaunai
Copy link
Member

gtest define macro causes issues

google/googletest#3390

sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h

edit: resolved my cmake refactor, declare CXX_STANDARD after deps

why isn't the root cmakelists.txt modified then ?

@PhilipDeegan
Copy link
Member Author

gtest define macro causes issues
google/googletest#3390

sed -i 's/# define GTEST_CAN_STREAM_RESULTS_ 1/# define GTEST_CAN_STREAM_RESULTS_ 0/g' subprojects/googletest/googletest/include/gtest/internal/gtest-port.h

edit: resolved my cmake refactor, declare CXX_STANDARD after deps

why isn't the root cmakelists.txt modified then ?

because I haven't merged the updates from https://github.com/PhilipDeegan/PHARE/blob/openacc_pusher/CMakeLists.txt#L17

@PhilipDeegan PhilipDeegan mentioned this pull request Feb 14, 2022
Open
@PhilipDeegan
Copy link
Member Author

close @nicolasaunai ?

@nicolasaunai
Copy link
Member

why closing if that helped being compliant with PGI at reasonable cost?
On the other hand, if we have no PGI build on the CI, it might be difficult to assess whether this PR is enough and stays enough in the future

@PhilipDeegan
Copy link
Member Author

rebase/retry with pgcc on tc

@PhilipDeegan
Copy link
Member Author

possibly move to fork, thoughts @nicolasaunai ?

@nicolasaunai nicolasaunai marked this pull request as draft May 9, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasaunai nicolasaunai nicolasaunai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
experimental gpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilipDeegan @nicolasaunai