Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement contributors page #15

Merged
merged 61 commits into from
Aug 7, 2020
Merged

Implement contributors page #15

merged 61 commits into from
Aug 7, 2020

Conversation

PHELAT
Copy link
Owner

@PHELAT PHELAT commented Jul 26, 2020

No description provided.

@PHELAT PHELAT added the enhancement New feature or request label Jul 26, 2020
@PHELAT PHELAT self-assigned this Jul 26, 2020
PHELAT added 22 commits July 28, 2020 22:08
@PHELAT
Populate contributors recycler with static data from view model
14d8337
@PHELAT
Create a sample contribution json file
8ebd788
@PHELAT
Add contributions.json file as an entry point for reading contributions
1dfab41
@PHELAT
Add :library:networking module
7d7942d
@PHELAT
Provide OkHttpClient dependency in :library:networking
d64578f
@PHELAT
Depend :feature:backup to :library:networking to use its OkHttpClient
1495270
@PHELAT
Depend :feature:contributors to :library:networking to use OkHttpClient
fc45996
@PHELAT
Implement ContributorsAPI.kt
99c04bb
@PHELAT
Provide ContributorsAPI in ContributorsNetworkModule.kt
54a3254
@PHELAT
Set logging interceptor for OkHttpClient in debug builds
0a581d0
@PHELAT
Fix url endpoint to contain branch's name for fetching contributions
7429e0a
@PHELAT
Request for contributions.json in contribution's page startup
010e9fd
@PHELAT
Rename ContributionsDataSource to ContributionsEntryDataSource
eb74aaf
@PHELAT
Implement ContributionsDataSource.kt
349b3c1
@PHELAT
Update contributions.json
f309c35
@PHELAT
Read data from ContributionsRepository.kt and update the ui
c2713ab
@PHELAT
Add progress for loading contributions
dec0880
@PHELAT
Move exceptionHandler to viewModelScope.launch
27bd21b
@PHELAT
Hide progress when an error occurs
482c4d6
@PHELAT
Add error view for when fetching contributions fails
ac9d79b
@PHELAT
Update contribution1.json
233cd0a
@PHELAT
Add contribution2.json
af31bae
PHELAT added 28 commits July 31, 2020 21:00
@PHELAT
Implement onReachTheEnd extension function on RecyclerView
a46f35f
@PHELAT
Implement PaginationLoadingItem
9bb0d64
@PHELAT
Add pagination ability for contributors list
dfeb6e4
@PHELAT
Move page handling logic to ViewModel
6023400
@PHELAT
Move onReachTheEnd's block invocation to a post call
90296f5
@PHELAT
Return emptyList when the required page is higher than what is available
5b89360
@PHELAT
Remove the top constraint from contributionNumber
993b75c
@PHELAT
Set on click listener for contributor items
7d57202
@PHELAT
Show a sheet when user clicks on a contributor item to show more details
8c5bbc5
@PHELAT
Update contribution3.json
d91ad3c
@PHELAT
Update contributions.json
622ed82
@PHELAT
Increase LoopWithTooManyJumpStatements's maxJumpCount to 2
91b9871
@PHELAT
Fix string fetching error in ContributorsViewModel.kt
afd6d17
@PHELAT
Add handshake icon in contributor's page toolbar
c5d165e
@PHELAT
Enable scrollbar for contributors list
432e84c
@PHELAT
Enable scrollbar for todolist recycler
3dc30a8
@PHELAT
Restrict contributors item layout's height to 56dp
807bfd2
@PHELAT
Add link to contribution option in contributor sheet
1785a96
@PHELAT
Update contribution3.json
a986b83
@PHELAT
Update contributions.json
4790d12
@PHELAT
Hide link to contribution when the link's empty or null
0135c03
@PHELAT
Handle translation contributions
74911c3
@PHELAT
Show appropriate error message when user's phone has no browsers
4be19a8
@PHELAT
Add contributor link property in contributor sheet
4e84403
@PHELAT
Remove contribution2.json and contribution3.json
bd15b09
@PHELAT
Merge branch 'master' of https://github.com/PHELAT/Tedu into contribu…
4fd7af8 
…tors-page

� Conflicts:
�	contributions.json
@PHELAT
Remove contribution1.json
86c3b62
@PHELAT
Merge branch 'release-1.0.0-alpha03' of https://github.com/PHELAT/Tedu …
4b50c3d 
…into contributors-page
@PHELAT PHELAT merged commit 9e91195 into release-1.0.0-alpha03 Aug 7, 2020
@PHELAT PHELAT deleted the contributors-page branch December 15, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PHELAT PHELAT

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PHELAT