Tests/UtilityMethodTestCase::skipJSCSSTestsOnPHPCS4: get rid of "risky test" warning #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y test" warning When the `@doesNotPerformAssertions` annotation is used, the test shows as risky when run in combination with PHPCS 4.x as it does perform assertions (expects an exception), but removing the annotation would make the test as risky when run in combination with PHPCS 3.x as in that case, it didn't perform an assertion. While a little hackish, this small tweak gets rid of the warnings in all circumstances.
jrfnl
force-pushed
the
testutils/skipjscsstest-avoid-risky-warning
branch
from
17feba0
to
9cf84a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
@doesNotPerformAssertionsannotation is used, the test shows as risky when run in combination with PHPCS 4.x as it does perform assertions (expects an exception), but removing the annotation would make the test report as risky when run in combination with PHPCS 3.x as in that case, it didn't perform an assertion.While a little hackish, this small tweak gets rid of the warnings in all circumstances.