Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/UtilityMethodTestCase::skipJSCSSTestsOnPHPCS4: get rid of "risky test" warning #242

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Tests/UtilityMethodTestCase::skipJSCSSTestsOnPHPCS4: get rid of "risky test" warning #242

merged 1 commit into from
Dec 22, 2020

Commits on Dec 22, 2020

  1. Tests/UtilityMethodTestCase::skipJSCSSTestsOnPHPCS4: get rid of "risk… 

    …y test" warning

When the `@doesNotPerformAssertions` annotation is used, the test shows as risky when run in combination with PHPCS 4.x as it does perform assertions (expects an exception), but removing the annotation would make the test as risky when run in combination with PHPCS 3.x as in that case, it didn't perform an assertion.

While a little hackish, this small tweak gets rid of the warnings in all circumstances.
    @jrfnl
    jrfnl committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    9cf84a1 View commit details
    Browse the repository at this point in the history