Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/UtilityMethodTestCase::skipJSCSSTestsOnPHPCS4: get rid of "risky test" warning #242

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Tests/UtilityMethodTestCase::skipJSCSSTestsOnPHPCS4: get rid of "risky test" warning #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Tests/TestUtils/UtilityMethodTestCase/SkipCSJSTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ public function skipJSCSSTestsOnPHPCS4()
/**
* Test that the skipJSCSSTestsOnPHPCS4() skips JS/CSS file tests on PHPCS 4.x.
*
* @doesNotPerformAssertions
*
* @return void
*/
public function testSkipJsCss()
Expand All @@ -68,6 +66,9 @@ public function testSkipJsCss()
// PHPUnit 4.
$this->setExpectedException($exception, $msg);
}
} else {
// Get rid of the "does not perform assertions" warning when run with PHPCS 3.x.
$this->assertTrue(true);
}

parent::skipJSCSSTestsOnPHPCS4();
Expand Down