Add support for fractional font sizes #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Word supports fractional font sizes like 8.5pt, but PHPWord doesn't.
Add background color support for text box element for Word writer
Word supports fractional font sizes like 8.5pt, but PHPWord doesn't.
…dded type hinting to settings class and unit test coverage for fractional (float) font size.
# Conflicts: # src/PhpWord/Settings.php
…dded type hinting to settings class and unit test coverage for fractional (float) font size.
|
I've added type hinting to the settings class and improved the set default font size method. It now supports both, int and float font sizes. I've also updated the unit tests to cover the new supported fractional font sizes. For an unknown reason the rebase command also added the new textbox code of my other patch that has already been merged to the master branch. P.S. The docs do not mention that only integer font sizes are supported. So there is no place to edit the docs. |
Progi1984
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Word supports fractional font sizes like 8.5pt, but PHPWord doesn't.
Fixes # (issue)
That fractional font size ist not supported as default font size, while font style elements support fractional font size.
Checklist:
composer run-script check --timeout=0and no errors were reported