Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize samples and write unsupported element to ODText and RTF #115

Merged
merged 12 commits into from
Mar 13, 2014

Conversation

ivanlanin
Copy link
Contributor

I created two folders under samples, i.e. resources and results. The names should explain their functions.

@Progi1984 Progi1984 added this to the 0.7.1 milestone Mar 12, 2014
@ivanlanin
Copy link
Contributor Author

@Progi1984 I've merged and checked @bskrtich and @jhfangying pull requests. But I haven't merged @RomanSyroeshko pull.

@ivanlanin
Copy link
Contributor Author

It's #118 and #119. I think @jhfangying would like to cancel #111 and replace it with #118.

@Progi1984
Copy link
Member

@ivanlanin I have merged independantly @bskrtich and @jhfangying pull requests. Can I merge your pull request ?

@ivanlanin
Copy link
Contributor Author

Later please. I'm still doing some more unit tests for the Writer. Thanks.

@ivanlanin
Copy link
Contributor Author

@Progi1984 I'm done (for now). Please merge. We now have 71.84% code coverage :)

@Progi1984
Copy link
Member

Summary:

Progi1984 added a commit that referenced this pull request Mar 13, 2014
Reorganize samples and write unsupported element to ODText and RTF
@Progi1984 Progi1984 merged commit 8e17598 into PHPOffice:develop Mar 13, 2014
@ivanlanin
Copy link
Contributor Author

Great! We have so many tests created within a week. I believe we'll be more stable once with more tests. Thanks for pushing this.

@Progi1984
Copy link
Member

@ivanlanin Yep, you have right... but it's all your work (mainly you, @gabrielbull & @RomanSyroeshko) which helped to get there. (0% to 72,52% of lines) Good job, guys :)

@ghost
Copy link

ghost commented Mar 14, 2014

It was a genuine pleasure. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants