-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize samples and write unsupported element to ODText and RTF #115
Conversation
@Progi1984 I've merged and checked @bskrtich and @jhfangying pull requests. But I haven't merged @RomanSyroeshko pull. |
It's #118 and #119. I think @jhfangying would like to cancel #111 and replace it with #118. |
@ivanlanin I have merged independantly @bskrtich and @jhfangying pull requests. Can I merge your pull request ? |
Later please. I'm still doing some more unit tests for the Writer. Thanks. |
@Progi1984 I'm done (for now). Please merge. We now have 71.84% code coverage :) |
Summary:
|
Reorganize samples and write unsupported element to ODText and RTF
Great! We have so many tests created within a week. I believe we'll be more stable once with more tests. Thanks for pushing this. |
@ivanlanin Yep, you have right... but it's all your work (mainly you, @gabrielbull & @RomanSyroeshko) which helped to get there. (0% to 72,52% of lines) Good job, guys :) |
It was a genuine pleasure. :) |
I created two folders under samples, i.e.
resources
andresults
. The names should explain their functions.