-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize macro delimiters in TemplateProcessor #2261
Conversation
4819f2b
to
7fb6f50
Compare
7fb6f50
to
fae44be
Compare
8f0e81e
to
17f9692
Compare
💡 The code does not pass the CI checks, I will take a look to fix this |
c4b226b
to
53c0700
Compare
53c0700
to
c4bcba9
Compare
Friendly ping 👋 |
Sorry, any update on the ability to merge it? |
@Progi1984 🙏 ❤️ |
lgtm! succesfully using it in production. |
Thanks @ismail1432 |
We use this in production since 8 months 👌 Thanks for merging for this awesome library 🔥 |
Thanks @ismail1432 & @benconda for the contribution. Sorry for the time. |
Sadly, the 3 methods don't seem to work anymore. When I try using it just doesn't recognize <> |
Description
Hello 👋
Congratulations on this huge project 🔥
I'm glad to open a pull request with new additions where the goal is to allow developers to customize macros delimiters with 3 methods:
setMacroOpeningChars
setMacroClosingChars
setMacroChars
You can see #2251 for more details.
💡 I ran
composer run-script check --timeout=0
and got an output that is not related to the PR:CamelCasePropertyName The property $TOCStyle is not named in camelCase.
✅ I duplicated all tests related to the TemplateProcessor with the customization of macros and it works like a charm.
I let you check the PR let me know if something is wrong or if you need more information.
Checklist:
composer run-script check --timeout=0
and no errors were reported