This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Fix partially supported callables deprecation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2950452412
💛 - Coveralls |
keradus
reviewed
Aug 29, 2022
| @@ -18,7 +18,7 @@ trait PolyfillTrait6 | |||
| { | |||
| public function expectException($exception) | |||
| { | |||
| if (\is_callable(['parent', 'expectException'])) { | |||
| if (\is_callable([parent::class, 'expectException'])) { | |||
There was a problem hiding this comment.
can we have a PHP CS Fixer rule that is automating that, pls? :)
There was a problem hiding this comment.
There is no way to determine whether ['parent', 'expectException'] is supposed to be a callable or just an array.
There was a problem hiding this comment.
but if it's passed as literal to is_callable etc, we can do the fix
|
Can we add all needed 8.x to CI, so we are sure the fix is enough to claim the 8.2 support? |
Not sure I follow, what do you mean? |
|
Sorry, I've mistaken this for PHPUnitGoodPractices/Traits#55 :) Rebased onto #19. |
|
no worry. thanks for the work! i will release new polyfill version now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecate_partially_supported_callables