Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeadlessUI v2 #50

Merged
merged 9 commits into from
May 15, 2024
Merged

HeadlessUI v2 #50

merged 9 commits into from
May 15, 2024

Conversation

lishaduck
Copy link
Member

Description

This PR migrates to HeadlessUI v2.
HeadlessUI v2 has floating-ui built in, which should really help the menus in the header.
It also ships with a checkbox and other components for forms.
Finally, it supports list virtualization.


Type of Change

  • 🗑️ Chore

Checklist

Checklist

Tested on

  • macOS 14

@lishaduck lishaduck self-assigned this May 9, 2024
Base automatically changed from next to main May 9, 2024 16:50
@lishaduck lishaduck force-pushed the headless2 branch 4 times, most recently from 2114ab3 to 72290c3 Compare May 9, 2024 18:55
@lishaduck lishaduck closed this May 10, 2024
@lishaduck lishaduck reopened this May 10, 2024
And get ourselves a floating ui!
@lishaduck lishaduck marked this pull request as ready for review May 13, 2024 02:38
@lishaduck lishaduck requested review from MattsAttack, iiAzui and a team as code owners May 13, 2024 02:38
@lishaduck
Copy link
Member Author

lishaduck commented May 13, 2024

Ok. After investigation, this works! 🚀
However, it requires DENO_FUTURE=1. This isn't set be default (Deno 2 is still some time away), and you can't set it on Deno Deploy. There is no workaround. 😞
As it stands, I guess we'll just wait for a response to denoland/fresh#2206 (comment) or denoland/deno#23784.

Gives us all of my wishlist for free!
They aren't interactive until hydrated anyway.
It looked like it had a forehead 🤣.
@lishaduck lishaduck enabled auto-merge May 15, 2024 16:35
@lishaduck lishaduck merged commit 4e52cbe into main May 15, 2024
3 checks passed
@lishaduck lishaduck deleted the headless2 branch May 15, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant