Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Info Labels don't Align Correctly #30

Closed
1 task done
lishaduck opened this issue Feb 3, 2024 · 20 comments · Fixed by #44
Closed
1 task done

Info Labels don't Align Correctly #30

lishaduck opened this issue Feb 3, 2024 · 20 comments · Fixed by #44
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lishaduck
Copy link
Member

lishaduck commented Feb 3, 2024

Contact Details

@lishaduck

What happened?

The info labels don't align correctly in fullscreen (in #28).

Reproduction steps

  1. Start the game.
  2. Go into fullscreen
  3. Notice that info labels are just floating

What should have happened?

They should stick to the top.

Date

2024-02-03

What device are you seeing the problem on?

Macbook Air 2020 (M1)

OS

macOS

Browser

Chrome

Context

Screenshot 2024-02-03 at 4 37 59 PM

Code of Conduct

  • I agree to follow this project's Code of Conduct

CC: @iiAzui

@lishaduck lishaduck added the bug Something isn't working label Feb 3, 2024
@lishaduck lishaduck assigned lishaduck and iiAzui and unassigned lishaduck Feb 3, 2024
@MattsAttack
Copy link
Contributor

I think I know how to fix this. I’ll work on it when I get home.

@lishaduck lishaduck assigned MattsAttack and unassigned iiAzui Feb 3, 2024
@lishaduck
Copy link
Member Author

I think I know how to fix this. I’ll work on it when I get home.

Sounds good!

@iiAzui
Copy link
Contributor

iiAzui commented Feb 3, 2024

Looks like your playing in a old version, the window size is never ment to go past 1280 x 800, also why are you in chrome

@lishaduck
Copy link
Member Author

Looks like your playing in a old version, the window size is never ment to go past 1280 x 800, also why are you in chrome

No, it's the latest. I guess the web build doesn't enforce the screen size, so we'll still need to fix it as it has to be a web game. As for chrome: why not? I was testing the web build.

@lishaduck
Copy link
Member Author

lishaduck commented Feb 3, 2024

... the window size is never ment to go past 1280 x 800...

...I guess the web build doesn't enforce the screen size, so we'll still need to fix it as it has to be a web game...

Tested it some more. That setting changes the default size but doesn't lock it on desktop.
It is this line doing it, right?

@iiAzui
Copy link
Contributor

iiAzui commented Feb 3, 2024

Idk it was in project settings
I also made it so it can't be risized

@lishaduck
Copy link
Member Author

Idk it was in project settings I also made it so it can't be risized

Ah. Must have accidentally reverted that. I do think we should fix it eventually, I think fixing that should be enough for now.

@lishaduck
Copy link
Member Author

Idk it was in project settings I also made it so it can't be risized

Ah. Must have accidentally reverted that. I do think we should fix it eventually, I think fixing that should be enough for now.

I see. That checkmark is weird. I'll push it after testing it in the browser.

@lishaduck
Copy link
Member Author

lishaduck commented Feb 3, 2024

Idk it was in project settings I also made it so it can't be risized

Ah. Must have accidentally reverted that. I do think we should fix it eventually, I think fixing that should be enough for now.

I see. That checkmark is weird. I'll push it after testing it in the browser.

Yeah. It isn't enforced in the browser, so that fix doesn't do anythingmuch. @MattsAttack, you can give it a shot.

@lishaduck lishaduck mentioned this issue Feb 4, 2024
@lishaduck
Copy link
Member Author

This is only mostly related, but I found another bug with the info labels:
Screenshot 2024-02-04 at 9 06 32 PM

The z-index of the bg is behind the rest of the content, which'll also need to get fixed.

@iiAzui
Copy link
Contributor

iiAzui commented Feb 5, 2024 via email

@MattsAttack
Copy link
Contributor

does it need to be a button or can i change it to a color rect?

@iiAzui
Copy link
Contributor

iiAzui commented Feb 5, 2024 via email

@MattsAttack
Copy link
Contributor

i gotchu

@lishaduck lishaduck added this to the State milestone Feb 6, 2024
@MattsAttack
Copy link
Contributor

We should probably edit the camera to just fit whatever resolution normal chrome uses. That way when the judges play it they can do full screen and it looks pretty

@lishaduck
Copy link
Member Author

We should probably edit the camera to just fit whatever resolution normal chrome uses. That way when the judges play it they can do full screen and it looks pretty

I was thinking we shouldn't care about the resolution and place them dynamically. Then they could do it fullscreen, but they don't have to.

@lishaduck
Copy link
Member Author

Aha! We can anchor them.

@lishaduck
Copy link
Member Author

I'm going to try to tackle this one next.

@lishaduck
Copy link
Member Author

I got it working! I just have to hook the score back up and it'll be done.

@lishaduck lishaduck mentioned this issue Feb 6, 2024
6 tasks
@lishaduck
Copy link
Member Author

Fixed it! Also found some bugs left over from #42, so it really ought to get merged whether or not you like the approach, for it can be changed later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants