Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

eda basic_scr mismatch in returned indices #68

Closed
malfarasplux opened this issue Apr 2, 2020 · 1 comment
Closed

eda basic_scr mismatch in returned indices #68

malfarasplux opened this issue Apr 2, 2020 · 1 comment

Comments

@malfarasplux
Copy link

malfarasplux commented Apr 2, 2020

test_biosppy_basic_scr.zip

eda.basic_scr method

The basic_scr seems to be cutting wrongly the returned indices. After detecting null-derivative singular points, onset and peak indices to be returned are arranged to be returned in pairs.

However, the way peaks and onsets are discarded leads to (peak,onset,peak,onset) returns instead of (onset,peak,onset,peak) returns that would be more meaningful.

https://github.com/PIA-Group/BioSPPy/blob/master/biosppy/signals/eda.py

@afonsocraposo
Copy link
Contributor

Fixed with commit 709c6a1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants