[QT][Performance] Memory leak re creating the row object instead of re initialize it. #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warrows
approved these changes
Sep 11, 2019
random-zebra
approved these changes
Sep 11, 2019
Fuzzbawls
approved these changes
Sep 13, 2019
Fuzzbawls
added a commit
that referenced
this pull request
Sep 13, 2019
… instead of re initialize it. 43ac65e [QT] Memory leak re creating the row object instead of re initialize it. (furszy) Pull request description: Memory leak issue solved and performance improvement over the chart load thread handler. The memory was increasing on every list screen movement because of the row object being re created on every refresh. ACKs for top commit: Warrows: ACK 43ac65e random-zebra: ACK 43ac65e Fuzzbawls: ACK 43ac65e Tree-SHA512: 666fa128c5cde13bfde0026a00ecca8afa8777559cc10e9007ec1d3bef1f6a87b041bf93c8ef267a99d875967bc910adafdb5a247c4402f355024325009f0b82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leak issue solved and performance improvement over the chart load thread handler.
The memory was increasing on every list screen movement because of the row object being re created on every refresh.