[zPIV][Cleanup] Zerocoin Cleanup 5: further main.cpp cleaning #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that activation height has passed, remove CheckPublicCoinSpendEnforced and simply reject any non-public zerocoin spend in AcceptToMemoryPool, without doing any further validation.
Outright reject mints from mempool. Only verify that they are no longer accepted after Zerocoin_Block_Public_Spend_Enabled
random-zebra
force-pushed
the
2020_Remove_Zerocoin_5
branch
from
974d7ac
to
80753f9
Compare
1 task
Fuzzbawls
approved these changes
Feb 8, 2020
|
Code ACK, reindex is failing due the |
furszy
approved these changes
Feb 13, 2020
furszy
added a commit
that referenced
this pull request
Feb 13, 2020
…aning 80753f9 [Cleanup] Remove multiple calls to chainActive in main functions (random-zebra) 3ddeeed [zPIV][Cleanup] Remove mapZerocoinspends (random-zebra) 334b760 [zPIV][Cleanup] remove ContextualCheckZerocoinMint (random-zebra) 39116fb [zPIV][Cleanup] Remove non-public zerocoin spend checks in ATMP (random-zebra) Pull request description: This removes unneeded checks in AcceptToMemoryPool and cleans up main.cpp file ACKs for top commit: Fuzzbawls: ACK 80753f9 furszy: Full sync, ACK 80753f9. Tree-SHA512: ee6b56a2e5db188e7bfc83649019a0ccd47dee0eaea3cfbd8c628ca10a0b0b89465c8c01c9d39535aba4374741291c021852d84ab1b5969ef4cf90fb30f257d8
furszy
added a commit
that referenced
this pull request
Feb 18, 2020
… checks 803f5dd [Trivial] Single method ScriptSigToSerializedSpend (random-zebra) dc0cc41 [Cleanup] Remove CoinSpend dependancy from CTxIn (random-zebra) 935c99c [Cleanup] Remove unused IsSerialKnown function in zpivchain.* (random-zebra) 1493473 [Cleanup] Remove CheckZerocoinMint main function (random-zebra) Pull request description: This is built on top of - [x] #1322 This removes `CheckZerocoinMint` (mints are disabled since block 1,686,229 and we can rely on checkpoints during IBD). Also does some minor cleanup in zpivmodule/zpivchain ACKs for top commit: furszy: Looking good, utACK 803f5dd Fuzzbawls: ACK 803f5dd Tree-SHA512: 5fe1c835ff95330be32561ca12e1c29cb46404be68f4ca7caf2e3e5c51ff9364ead8bc781284e3c49dc0bd5efac28d3f24a901e92e3cc0d4b7af17b2146eaf50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unneeded checks in AcceptToMemoryPool and cleans up main.cpp file