[Refactor] ChainParams::consensus - Part 1 #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1328 merged, rebase needed. |
random-zebra
force-pushed
the
2020_consensus_namespace
branch
from
a7011e7
to
0de2658
Compare
|
Rebased |
|
Can we split this in two PRs for a quicker testnet Possibly up until |
and remove extra nMinimumChainWork / defaultAssumeValid
random-zebra
force-pushed
the
2020_consensus_namespace
branch
from
0de2658
to
64465b7
Compare
1 task
|
Done. Second part split in #1344 |
random-zebra
changed the title
furszy
approved these changes
Feb 20, 2020
Fuzzbawls
approved these changes
Feb 22, 2020
furszy
added a commit
that referenced
this pull request
Feb 28, 2020
92221b1 [Cleanup] Remove ChainParams::DefaultMinerThreads (random-zebra) 98494ab [Refactor] Consensus: move other consensus params to the struct (random-zebra) 7c673bf [Refactor] Consensus: masternode/budget-related fields (random-zebra) 7736d6c [Refactor] Consensus: zerocoin-related fields (random-zebra) 0b63af4 [Refactor] ChainParams: move genesis creation at the beginning (random-zebra) 1e5a33d [Refactor] Consensus: wrapped serials params (nSupplyBeforeFakeSerial) (random-zebra) 70c4ae5 [Refactor] Consensus: height-based activations (random-zebra) Pull request description: Second part of - [x] #1341 Split as individual PR for ease of review. ACKs for top commit: Fuzzbawls: ACK 92221b1 furszy: utACK 92221b1. Tree-SHA512: a3f1c10fc568e264039d2fc5a4dedc01d947b380e55c5170679598cb6859274c73157fb9ade6f5345a9781b9028943629b304aac8c3b0d7849946bdaed85fb52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on
Populates the
consensusstruct with all relevant consensus parameters.Resets
nMaxMoneyOutas chain param (with different value for TestNet).Cleans up several unneeded fields in ChainParams.
EDIT: Current PR has been split in two. Second part is #1344