Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move zerocoin checks out of main #1342

Merged

Conversation

Fuzzbawls
Copy link
Collaborator

This is PR is the final part of breaking up #1209 into individual narrow-focused PRs. For this one, the original commit had too many merge conflicts, so it was easier/faster for me to just start from a clean slate and re-do the commit. (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209)

Reference Commit:
Fuzzbawls@547ca6c

This moves all zerocoin checking methods out of main.cpp/h into two new
files in the consensus subdir: zerocoin_verify.cpp/h

@Fuzzbawls Fuzzbawls added this to the 4.1.0 milestone Feb 19, 2020
@Fuzzbawls Fuzzbawls self-assigned this Feb 19, 2020
@Fuzzbawls Fuzzbawls force-pushed the 2020_move-zerocoin-checks branch 2 times, most recently from 69d541c to a7ea3a9 Compare February 19, 2020 23:55
src/main.h Outdated Show resolved Hide resolved
furszy
furszy previously approved these changes Feb 24, 2020
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side from the minor object type change, utACK 15d8f3f.

src/consensus/zerocoin_verify.cpp Outdated Show resolved Hide resolved
This moves all zerocoin checking methods out of main.cpp/h into two new
files in the `consensus` subdir: zerocoin_verify.cpp/h
@Fuzzbawls
Copy link
Collaborator Author

rebased

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK bd49362

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase utACK bd49362.

furszy
furszy approved these changes Feb 25, 2020
@random-zebra random-zebra merged commit dc530c0 into PIVX-Project:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants