[Bug] Fix g_best_block initialization in ABC #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some more context. |
random-zebra
force-pushed
the
202003_g_best_block_initialization
branch
2 times, most recently
from
602dcf2
to
f3dc201
Compare
random-zebra
force-pushed
the
202003_g_best_block_initialization
branch
from
f3dc201
to
7d9adb8
Compare
furszy
approved these changes
Mar 25, 2020
Fuzzbawls
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_best_blockholds a cached best block hash.This is updated during
ActivateBestChain(inUpdateTip).Problem: at startup, the object is not initialized until a new block arrives (
ActivateBestChainStepis not called) thusg_best_block != chainActive.Tip()->GetBlockHash()so, if the client stakes before receiving a new block, that stake gets orphaned.In case of segregated devnet with just one staker, it is impossible to move the chain at all.