Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove old governancepage and proposalframe code #1461

Merged
merged 1 commit into from
Mar 27, 2020
Merged

[Cleanup] Remove old governancepage and proposalframe code #1461

merged 1 commit into from
Mar 27, 2020

Conversation

akshaynexus
Copy link

After the v4.0 UI revamp,the old governance page and its proposalframe code hasnt been used anywhere.This PR removes currently unused forms,css code and files related to the old governance page UI

@random-zebra
Copy link

Hei @akshaynexus thanks for this cleanup.
governancepage.cpp and proposalframe.cpp should be removed from qt's CMakeLists as well, to allow cmake builds and keep Travis happy.

@random-zebra random-zebra added this to the 4.1.0 milestone Mar 26, 2020
@akshaynexus
Copy link
Author

Done,should be compiling on cmake now.

random-zebra
random-zebra approved these changes Mar 26, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3e02ff7

furszy
furszy approved these changes Mar 27, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3e02ff7

Fuzzbawls
Fuzzbawls approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3e02ff7

@Fuzzbawls Fuzzbawls merged commit 0a63983 into PIVX-Project:master Mar 27, 2020
akshaynexus added a commit to ZENZO-Ecosystem/ZENZO-Core that referenced this pull request Mar 30, 2020
@akshaynexus
Merge PIVX-Project#1461: [Cleanup] Remove old governancepage and prop…
7d06bd6 
…osalframe code

3e02ff7 [Cleanup] Remove old governancepage and proposalframe code (Akshay)

Pull request description:

  After the v4.0 UI revamp,the old governance page and its proposalframe code hasnt been used anywhere.This PR removes currently unused forms,css code and files related to the old governance page UI

ACKs for top commit:
  random-zebra:
    utACK 3e02ff7
  furszy:
    utACK 3e02ff7
  Fuzzbawls:
    ACK 3e02ff7

Tree-SHA512: 4ba4a15989cebe7956219644eccbd6284f9244b413d74c8440ce4dd812e92e9437edd1b4435ecafcfd786fbad51dfd8d03d84fcdaffb0228acce2187e5d78e8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random-zebra random-zebra random-zebra approved these changes

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@furszy furszy furszy approved these changes

Assignees

@akshaynexus akshaynexus

Labels
Cleanup
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@akshaynexus @random-zebra @furszy @Fuzzbawls