-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QT] Add password mismatch warnings #1607
[QT] Add password mismatch warnings #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, concept ACK. Left few comments.
Added suggestions and updated the PR description with new images of the compiled PR. |
Good job 👍 works as intended and code looks good. Only minor non-blocking nit would be rename |
Renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8797114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working good 👌 . For the next time, would be good to squash the commits, the last commit change is purely over the new introduced code.
ACK 8797114 and merging..
This closes #1605 by adding a warning message & deactivating the "OK" button when the two passphrase fields do not match eachother.
As this warning is in the same area as the caps lock warning, the two have been merged into a single "passWarningLabel" which "stacks" warnings ontop of eachother, so both warnings can be shown independently, or both at once.
This PR ensures a user cannot proceed via the "OK" button until: