[Refactor][GUI] Set static texts in .ui files + add missing tr() #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202005_GUI_translations-and-strings
branch
4 times, most recently
from
4856626
to
a8f5b1f
Compare
random-zebra
force-pushed
the
202005_GUI_translations-and-strings
branch
from
a8f5b1f
to
cc60e50
Compare
|
All comments addressed |
furszy
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set initial / static texts for widgets and dialogs in the .ui files instead of in the .cpp files, with
notrwhere needed. Also addtr()where missing (ref: #1600).Finally clean up styling (missing spaces, branches on newlines).