[GUI] CoinControlDialog fix SelectAll / UnselectAll #1612
Conversation
There was a problem hiding this comment.
changed my opinion in the middle of writing; so just a "comment". Also, there's some other strange behavior when switching between the two coin controls, but i checked against 4.1 release and I see the same behavior; so it wasn't introduced with this or #1611. I'll write up separately; but if you want to play around, go into coin control in the send page, then out and into coin control in the delegation page, and you'll see different states (i.e. one will be highlighted like there's selections, the other won't, even though there is selected UTXOs).
More on that later. for now, just see below regarding [pure opinion] on the behavior of the quantity selected decision.
Aside of that; the root issue [select all when all coins have been spent being reset] is ACK.
random-zebra
force-pushed
the
202005_GUI_coincontrol-fix2
branch
from
fc82ee8
to
95b6eb3
Compare
|
Rebased on master, now that #1611 has been merged and slightly modified the logic as per @CaveSpectre11's suggestion: when there's more selected utxos than unselected, the button is in "Unselect All" mode and, vice-versa, when there's more unselected then selected, the button switches to "Select All" mode. |
random-zebra
force-pushed
the
202005_GUI_coincontrol-fix2
branch
from
95b6eb3
to
28aef33
Compare
Fuzzbawls
changed the title
There was a problem hiding this comment.
Looks great (with same nit). Will fire a build up tonight but code-wise utACK 28aef33
Thank you for considering (and running with) the more than/less than half idea.
- use directly the checked state of the button pushButtonSelectAll,
instead of caching it in fSelectAllToggled
- when the button is in checked ("Unselect all") state, reset to its
initial state (unchecked, with "Select all" label) if all the entries
are either manually deselected, or automatically cleared after a spend)
random-zebra
force-pushed
the
202005_GUI_coincontrol-fix2
branch
from
28aef33
to
2ad58fd
Compare
|
Rebased and fixed nit. |
|
Merging... |
Based on top of
Only last commit is new.
This updates the flow of the toggle button SelectAll/UnselectAll in the coin control dialog (
pushButtonSelectAll).use directly the checked state of the button, instead of caching it in a separate variable
fSelectAllToggled.when the button is in checked ("Unselect all") state, reset it to its initial state (unchecked, with "Select all" label) if all the entries are either manually deselected, or automatically cleared after a spend)
Closes point n.3 of #1609