Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2P][RPC] Rework addnode behaviour #1640

Merged
merged 2 commits into from
May 26, 2020
Merged

[P2P][RPC] Rework addnode behaviour #1640

merged 2 commits into from
May 26, 2020

Commits on May 23, 2020

  1. Rework addnode behaviour 

    * Use CNode::addeName to track whether a connection to a name is already open
  * A new connection to a previously-connected by-name addednode is only opened when
    the previous one closes (even if the name starts resolving to something else)
  * At most one connection is opened per addednode (even if the name resolves to multiple)
* Unify the code between ThreadOpenAddedNodeConnections and getaddednodeinfo
  * Information about open connections is always returned, and the dns argument becomes a dummy
  * An IP address and inbound/outbound is only reported for the (at most 1) open connection
    @sipa @Fuzzbawls
    sipa authored and Fuzzbawls committed May 23, 2020
    Configuration menu
    Copy the full SHA
    cdc1d9f View commit details
    Browse the repository at this point in the history

  2. Randomize name lookup result in ConnectSocketByName

    @sipa @Fuzzbawls
    sipa authored and Fuzzbawls committed May 23, 2020
    Configuration menu
    Copy the full SHA
    5e79989 View commit details
    Browse the repository at this point in the history