[CMake] Define MAC_OSX for cmake builds on macOS #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few places in our code rely on this precompiler definition, most notably in the datadir and zk-params dir default values. Autotools sets this automatically, but it is not passed into `pivx-config.h` as it isn't necessary for autotools builds. Instead of modify the autotools configure script to pass this define into the config file, simply define it in `CMakeLists.txt`
furszy
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places in our code rely on this precompiler definition, most
notably in the datadir and zk-params dir default values. Autotools sets
this automatically, but it is not passed into
pivx-config.has itisn't necessary for autotools builds.
Instead of modify the autotools configure script to pass this define
into the config file, simply define it in
CMakeLists.txt