Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Cleanup getbalance methods that are not fulfilling any purpose. #1832

Merged
merged 2 commits into from
Sep 4, 2020
Merged

[Wallet] Cleanup getbalance methods that are not fulfilling any purpose. #1832

merged 2 commits into from
Sep 4, 2020

Conversation

furszy
Copy link

@furszy furszy commented Sep 2, 2020

auto-descriptive title, removed the following methods:
CWalletTx::GetUnlockedCredit and CWallet::GetUnlockedCoins CWallet::GetLockedWatchOnlyBalance and CWalletTx::GetLockedWatchOnlyCredit

@furszy furszy self-assigned this Sep 2, 2020
@furszy furszy changed the title [Wallet] Cleanup getbalance methods that doesn't fulfill any purpose. [Wallet] Cleanup getbalance methods that are not fulfilling any purpose. Sep 2, 2020
random-zebra
random-zebra reviewed Sep 2, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locked WatchOnly balance... ugh.
Nice one. utACK 3652fd5

@furszy
Copy link
Author

furszy commented Sep 4, 2020

purely unused code removal, merging this one..

@furszy furszy merged commit c14d130 into PIVX-Project:master Sep 4, 2020
@random-zebra random-zebra added this to the 4.3.0 milestone Sep 10, 2020
@furszy furszy deleted the 2020_wallet_cleanup_unused_getbalance_methods branch November 29, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@random-zebra random-zebra random-zebra approved these changes

Assignees

@furszy furszy

Labels
Cleanup Wallet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@furszy @random-zebra