[RPC][BUG] Fix 'mnfinalbudget show' returning a single budget #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because all of them have the same name (object key). Fix it by adding the nHash to the object key (removing it from the object value).
Merged
2 tasks
Fuzzbawls
approved these changes
Oct 3, 2020
furszy
added
the
Needs Release Notes
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the RPC
mnfinalbudget show.All finalized budgets have the same name (
"main").This is used as key for the object returned by the RPC, therefore only one single finalized budget is returned (despite there being many more in the map).
Fix it by adding the hash to the object key (removing it from the object value).
Side note: why finalized budgets do even need a
strBudgetName(which is the same for every one) is a mystery to me... but, since it's part of the broadcast, we can't just outright remove it, it needs to be guarded with a network upgrade (future work).