[BUG][GUI] Fix wallet crashing on faq-buttons press #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some section was removed, but the safe-check in setSection and some button connection were not updated. Introduce SettingsFaqWidget::Section enumeration and replace bare integers to define FAQs sections.
random-zebra
added
GUI
Bug
Needs Backport
Fuzzbawls
approved these changes
Oct 4, 2020
furszy
approved these changes
Oct 5, 2020
random-zebra
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reported today on discord.
Wallet (GUI 4.3.0) crashes when the FAQ buttons from the masternode widget are pressed.
Cause:
The FAQs sections have been recently reduced to only 6 (old zerocoin sections have been removed).
But the buttons in the masternode widget still reference the old indexes (9 and 10), which are now out of bounds.
Further, the safety check inside
setSection, still has the old (10) max value hardcoded, so does not prevent this.Fix:
This clearly shows the difficulty in maintaining code with fixed magic numbers (which depend on a list of objects that may be modified in future releases).
So, let's introduce a proper enumeration inside
SettingsFaqWidget, and use that to manage the sections, instead of just integers.