[RPC] refactor autocombine into specific commands #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
reviewed
Mar 17, 2021
Fuzzbawls
force-pushed
the
2021_rpc-refactor-autocombine
branch
from
27fcdea
to
f02f240
Compare
Fuzzbawls
force-pushed
the
2021_rpc-refactor-autocombine
branch
from
f02f240
to
60058d6
Compare
|
Rebased and updated to address feedback. The setter now doesn't allow a threshold value below I've also added a simple functional test for the two new commands |
Fuzzbawls
force-pushed
the
2021_rpc-refactor-autocombine
branch
from
60058d6
to
84f9cab
Compare
Introduces `setautocombinethreshold` and `getautocombinethreshold`, similar to `setstakesplitthreshold`, thus deprecating the now-obsolete `autocombine` command (to be removed in a future version).
Fuzzbawls
force-pushed
the
2021_rpc-refactor-autocombine
branch
from
84f9cab
to
2444de9
Compare
furszy
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
autocombinecommand is limited to whole numbers only, and infringes on our RPC standards by not providing deterministic output even when successfully changing the setting.This PR addresses the deterministic issue as well as makes the setting information available to
getwalletinfo