-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] git-subtree-check.sh updated to latest upstream #2473
[Backport] git-subtree-check.sh updated to latest upstream #2473
Conversation
2406eff
to
5025ba5
Compare
rebased due conflicts with a recent merged PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 5025ba5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 5025ba5 with a note:
The location of this shell script was changed in #2452 (from contrib/devtools
to test/lint
). when that PR was merged it prompted this to be rebased. a previous comment here was to PIVXify the help text, which included referencing the (correct-at-the-time) script's location in the tree as contrib/devtools
.
Post #2452 merge and after rebase, the help text should be referencing test/lint
. Other than that, GTG
yeah, will push it shortly. |
Plus use bls-repo in the help example.
5025ba5
to
855aa70
Compare
Updated, can get merged right away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 855aa70 and merging...
Pulled latest
git-subtree-check.sh
changes from upstream. So it's easier to verify the new subtree that is being included in #2419.