Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix app always triggering the tutorial dialog if no manual '-wallet' arg is provided. #2490

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

furszy
Copy link

@furszy furszy commented Jul 29, 2021

As the intro dialog check is executed before calling the 'WalletParameterInteraction()' function in the GUI, the '-wallet' arg soft set is not being performed, skipping the for-loop wallet path check. Always launching the tutorial dialog even when there is an already existent wallet.

@furszy furszy self-assigned this Jul 29, 2021
@furszy furszy added the Bug label Jul 29, 2021
@furszy furszy added this to the 6.0.0 milestone Jul 29, 2021
…rg is provided.

As the intro dialog check is executed before calling the 'WalletParameterInteraction()' function in the GUI, the '-wallet' arg soft set is not being performed, skipping the for-loop wallet path check. Always launching the tutorial dialog even when there is an already existent wallet.
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ACK c01240a

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c01240a

@random-zebra random-zebra merged commit fc9ecda into PIVX-Project:master Jul 30, 2021
@furszy furszy deleted the 2021_fix_wallet_init branch November 29, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants