[Net_processing] Do not log "notfound" msg as unknown. #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the enum to the top, and remove a deceptive TODO comment. Adaptation of btc@2c09a5209ab00573a2422e1e65c437a6e2f59624
furszy
force-pushed
the
2021_net_notfound
branch
from
73e1b21
to
800ed43
Compare
Fuzzbawls
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouped few findings that discovered testing #2659.
The "not found" message is not being processed properly. Logging an unnecessary "unknown message type" error.
It become even more evident syncing a peer running 2659 from a normal network peer, because of the non-updated peer blockage from relaying budget items that described there (the
ClearSeenbug..).Then some extra refactoring, removing unneeded chain height argument in
PushTierTwoGetDataRequestand adapted 2c09a52 to our sources as well.