Kill 'zpivchain' files and, with them, many circular dependencies. #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
furszy
changed the title
furszy
force-pushed
the
2021_fix_circular_dependencies
branch
from
08630df
to
4233f28
Compare
|
rebased, conflicts solved. |
it's only used there and has nothing to do with the "zpivchain" (whatever that was). Plus clean unneeded dependencies.
And, as it's only used inside this function, merge it with the IsTransactionInChain function.
…p files. Plus, clean zpivchain solved circular dependencies
furszy
force-pushed
the
2021_fix_circular_dependencies
branch
from
4233f28
to
aab4705
Compare
Fuzzbawls
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This files were only existing to create circular dependencies and slow down the compilation process.
Refactored the sources to be able to move
TxOutToPublicCoinandTxInToZerocoinSpendtozpivmoduleandIsSerialInBlockchaintozerocoin_verify.Fixing the following circular dependencies:
This changes are the building blocks for the zerocoin coinspends cache work that will be pushing on a follow-up PR, which will speedup the chain synchronization process during the zerocoin window.