Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] fix ATMP call not contemplating the "missing inputs" error #2736

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

furszy
Copy link

@furszy furszy commented Jan 27, 2022

As AcceptToMemoryPool does not set the invalid state if the tx inputs requirements are not met, the wallet returns an empty validation state which ends up with an unknown/empty error message being presented to the user.

@furszy furszy self-assigned this Jan 27, 2022
@furszy furszy changed the title [wallet] fix ATMP call not contemplating the "missing inputs" error [WIP][wallet] fix ATMP call not contemplating the "missing inputs" error Jan 27, 2022
@furszy furszy added the Wallet label Jan 27, 2022
@furszy furszy changed the title [WIP][wallet] fix ATMP call not contemplating the "missing inputs" error [wallet] fix ATMP call not contemplating the "missing inputs" error Jan 28, 2022
src/wallet/wallet.cpp Outdated Show resolved Hide resolved
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8f762f3

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f762f3

@furszy furszy merged commit 3aefab3 into PIVX-Project:master Feb 19, 2022
@Fuzzbawls Fuzzbawls added this to the 5.5.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants