Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared lib versioning fix #131

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Shared lib versioning fix #131

merged 4 commits into from
Mar 26, 2020

Conversation

PJK
Copy link
Owner

@PJK PJK commented Mar 22, 2020

A (hopefully) better attempt to fix #52

@panlinux
Copy link

When this lands, does it mean a new release, perhaps 0.7.0?

@PJK
Copy link
Owner Author

PJK commented Mar 23, 2020

When this lands, does it mean a new release, perhaps 0.7.0?

I think that would make sense. And probably the sooner the better, #75 was only "fixed" in 0.6, hopefully most clients would skip that release and not run into #52.

@panlinux
Copy link

I wouldn't mind a 0.6.1 with this fix in place, if you are ok with changing the soname one more time jumping from libcbor.so.0.6.0 in 0.6.0 to libcbor0.6 in 0.6.1. And then maybe flag 0.6.0 as "do not use please", although it works just the same.

@PJK PJK merged commit 58b9a62 into master Mar 26, 2020
@PJK
Copy link
Owner Author

PJK commented Mar 26, 2020

I will push a new release shortly. Thanks for digging into this @panlinux!

@panlinux
Copy link

Thanks!

I was just looking at the 0.6.1 tarball, and unless I'm mistaken it has more changes, not just what was mentioned in https://github.com/PJK/libcbor/releases/tag/v0.6.1

This includes two "breaking" changes as well, mentioned in CHANGELOG.md:
v0.6.0...v0.6.1#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

Did you release master perhaps?

@PJK
Copy link
Owner Author

PJK commented Mar 27, 2020

Looks like a botched cherrypick 🤦‍♂ Thanks, will look into resolving that soon.

@PJK
Copy link
Owner Author

PJK commented Mar 28, 2020

Fixed in place, this should work: v0.6.0...v0.6.1

@PJK PJK mentioned this pull request Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homebrew dylib version is wrong
2 participants