-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying a 'primary' domain for the certificate #17
Conversation
I think there should also be a new Cmdlet |
Re: I was wondering if it might not be better to leave |
I've seen you implemented the PrimaryName on Complete-Order at first - this would also make any change of the Order object unneccesary. Also there the option to merge (instead of reset) the list of identifiers on Update-Order, so the first identifier is always the same. Nevertheless the CertificateRequest Object might be an Option, but I'd like to keep the order as the "principal object". So an order could have a CSRSettings. I did not dig too deep into the Certificate Issuance of LE or what is supported in CSR and what not, so if it's more than just the CN, that could be an interesting approach. FriendlyName is - as far as I know - more a Windows thing, is it? I'll open an Issue to discuss this further. |
Currently the ordering of domains supplied to
New-ACMEOrder
is not preserved, because theAcmeOrder
object is created from the server response which, in practice, appears to return the Identifiers sorted alphabetically.These updates:
PrimaryDomain
field to theAcmeOrder
classAcmeOrder
constructor logic to initializePrimaryDomain
to the firstIdentifier
so it should be compatible with old CliXML exports.PrimaryDomain
parameter to theNew-Order
cmdletNew-Order
cmdlet to set the initial value ofPrimaryDomain
on theAcmeOrder
to the value of thePrimaryDomain
parameter if specified, or the value of the first suppliedIdentifier
otherwise.primaryDomain
parameter to theGenerateCsr
method that is used as the CN/Subject of the certificate