fix(onpolicy_adapter): fix the calculation of last state value #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: borong <borongzh@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com> Co-authored-by: borong <borongzh@gmail.com> Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
…nment#147) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…thms (PKU-Alignment#148) Co-authored-by: borong <borongzh@gmail.com> Co-authored-by: Gaiejj <524339208@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: borong <borongzh@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ruiyang sun <rockmagma02@gmail.com> Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com> Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com> Co-authored-by: Gaiejj <524339208@qq.com> Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com> Co-authored-by: Ruiyang Sun <rockmagma02@gmail.com> Co-authored-by: Jiayi Zhou <108712610+Gaiejj@users.noreply.github.com> Co-authored-by: 1Asan <99461435+1Asan@users.noreply.github.com> fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122) fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignment#131) fix typo. (PKU-Alignment#134) fix(ppo): fix entropy loss (PKU-Alignment#135) fix bugs (PKU-Alignment#136) fix: support new config for exp_grid (PKU-Alignment#142) fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145) fix(on-policy): fix the second order algorithms performance (PKU-Alignment#147)
…lignment#162) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: borong <borongzh@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #164 +/- ##
=======================================
Coverage 86.48% 86.49%
=======================================
Files 80 80
Lines 3730 3740 +10
=======================================
+ Hits 3226 3235 +9
- Misses 504 505 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
3 tasks
zmsn-2077
pushed a commit
that referenced
this pull request
Mar 26, 2023
Co-authored-by: borong <borongzh@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The #162, exist some bugs.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)