Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(saute, simmer): support saute rl and clean the code #209

Merged
merged 127 commits into from
Apr 8, 2023

Conversation

zmsn-2077
Copy link
Member

Description

feat(saute, simmer): support saute rl and clean the code

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

rockmagma02 and others added 30 commits March 15, 2023 02:53
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
…nment#147)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…thms (PKU-Alignment#148)

Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: Gaiejj <524339208@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
Co-authored-by: Gaiejj <524339208@qq.com>
Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: Ruiyang Sun <rockmagma02@gmail.com>
Co-authored-by: Jiayi Zhou <108712610+Gaiejj@users.noreply.github.com>
Co-authored-by: 1Asan <99461435+1Asan@users.noreply.github.com>
fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122)
fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignment#131)
fix typo. (PKU-Alignment#134)
fix(ppo): fix entropy loss (PKU-Alignment#135)
fix bugs (PKU-Alignment#136)
fix: support new config for exp_grid (PKU-Alignment#142)
fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145)
fix(on-policy): fix the second order algorithms performance (PKU-Alignment#147)
…lignment#162)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
Co-authored-by: Gaiejj <524339208@qq.com>
Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: Ruiyang Sun <rockmagma02@gmail.com>
Co-authored-by: Jiayi Zhou <108712610+Gaiejj@users.noreply.github.com>
Co-authored-by: 1Asan <99461435+1Asan@users.noreply.github.com>
fix(algo): fix no return in algo_wrapper::learn (PKU-Alignment#122)
fix(logger, wrapper): support csv file and velocity tasks (PKU-Alignment#131)
fix typo. (PKU-Alignment#134)
fix(ppo): fix entropy loss (PKU-Alignment#135)
fix bugs (PKU-Alignment#136)
fix: support new config for exp_grid (PKU-Alignment#142)
fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145)
fix(on-policy): fix the second order algorithms performance (PKU-Alignment#147)
@zmsn-2077 zmsn-2077 marked this pull request as draft April 8, 2023 11:01
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj marked this pull request as ready for review April 8, 2023 19:23
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit b0a0699 into PKU-Alignment:dev Apr 8, 2023
4 checks passed
@Gaiejj Gaiejj deleted the dev-saute branch April 8, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants