Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kusto Query Language (KQL) #968

Merged
merged 6 commits into from
Mar 14, 2021
Merged

Add Kusto Query Language (KQL) #968

merged 6 commits into from
Mar 14, 2021

Conversation

diligent176
Copy link
Contributor

@diligent176 diligent176 commented Mar 11, 2021

Kusto Query Language (.kql) for Azure Log Analytics

image

@diligent176
Copy link
Contributor Author

diligent176 commented Mar 11, 2021

After reading other PR conversations, I see there might be 1 or 2 issues in my PR.

  1. The SVG uses base64 image string instead of standard vectors (will see if I can improve svg and adjust viewbox to 24x24).
  2. Kusto isn't a recognized language identifier in:
    https://code.visualstudio.com/docs/languages/identifiers#_known-language-identifiers
    But, many others in languageIcons.ts aren't defined in the link above as well. Is this a problem?

@diligent176 diligent176 marked this pull request as draft March 11, 2021 15:10
@PKief
Copy link
Member

PKief commented Mar 11, 2021

Hi @diligent176, regarding your first point, it is really important that the SVG is really made of vectors and not simply a wrapper of an image. So base64 is not acceptable. But as I take a look at the logo I think that it could be recreated easily as an SVG vector graphic. You can ping me if you need some help here.

Regarding the language identifiers it is not necessary that they are listed in the link that you provided. These are just the language identifiers which are supported by VS Code by default. The other language identifiers can be added by installing some additional extensions. Probably there's an extension for KQL that provides some support for this language, right? So don't worry about this.

@diligent176
Copy link
Contributor Author

Thanks for the quick reply @PKief!
I agree it's a simple shape, I could almost re-draw those shapes by hand in Inkscape.
I'm new to SVG format. I'm wondering if there's any tool or method you know to "convert" shapes from PNG into vectors. I'll see what I can figure out.

@diligent176 diligent176 marked this pull request as ready for review March 12, 2021 03:10
@diligent176
Copy link
Contributor Author

diligent176 commented Mar 12, 2021

I found a nice tool at https://autotracer.org - did a good job tracing the png and saving a vector file. Easy peasy.
Then I found an even better one, at https://vectorizer.io

@PKief I have perfected the masterpiece now. ;-)

@PKief PKief self-requested a review March 14, 2021 22:22
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly updated the scaling of the icon a little bit so that there's some space around it. This additional space can be found in every icon, so just to be consistent here. It looks pretty nice, I like it :)

@PKief PKief merged commit d1d6ed6 into material-extensions:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants