feat: Introduce REF=
#1249
Closed
feat: Introduce REF=
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volsa
commented
Jun 20, 2024
Comment on lines
+162
to
+164
| #[token("REF=")] | ||
| KeywordReferenceAssignment, | ||
|
|
There was a problem hiding this comment.
How strict do we want to be here, i.e. should spaces between REF and = be allowed or no?
There was a problem hiding this comment.
I'd treat this the same as e.g. : =
volsa
force-pushed
the
volsa/ref-assignment
branch
from
4d61e7e
to
acd5770
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1249 +/- ##
==========================================
+ Coverage 91.11% 91.18% +0.07%
==========================================
Files 153 155 +2
Lines 44816 45521 +705
==========================================
+ Hits 40833 41508 +675
- Misses 3983 4013 +30 ☔ View full report in Codecov by Sentry. |
|
Closing this in favor of #1251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.