Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support binary expressions for pointers (#416) #422

Merged

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Dec 15, 2021

No description provided.

@99NIMI 99NIMI linked an issue Dec 15, 2021 that may be closed by this pull request
@99NIMI 99NIMI requested a review from ghaith December 15, 2021 09:44
@99NIMI 99NIMI marked this pull request as draft December 15, 2021 09:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #422 (2d72ee6) into master (5729541) will increase coverage by 0.07%.
The diff coverage is 99.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   93.12%   93.19%   +0.07%     
==========================================
  Files          31       31              
  Lines       11292    11411     +119     
==========================================
+ Hits        10516    10635     +119     
  Misses        776      776              
Impacted Files Coverage Δ
src/codegen/generators/expression_generator.rs 88.05% <99.13%> (+0.99%) ⬆️
src/ast.rs 92.95% <100.00%> (+1.03%) ⬆️
src/typesystem.rs 94.88% <100.00%> (-0.17%) ⬇️
src/validation/stmt_validator.rs 98.32% <100.00%> (ø)
src/index.rs 97.22% <0.00%> (-0.75%) ⬇️
src/validation.rs 89.65% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5729541...2d72ee6. Read the comment docs.

@99NIMI 99NIMI marked this pull request as ready for review December 16, 2021 14:18
@99NIMI 99NIMI requested a review from ghaith December 20, 2021 09:56
@ghaith ghaith merged commit f02a6e6 into master Jan 3, 2022
@ghaith ghaith deleted the issue-416-Pointer_Arithmetics_still_cannot_generate_correctly branch January 3, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointer Arithmetics still cannot generate correctly
3 participants