Threads info and UAF checker info #22
Conversation
| @@ -21,7 +23,8 @@ RUN mkdir src | |||
| WORKDIR src | |||
| RUN git clone https://github.com/Boolector/btor2tools.git | |||
| RUN git clone https://github.com/Boolector/boolector.git | |||
| RUN git clone https://github.com/PLSysSec/sys.git | |||
| RUN git clone https://github.com/Gavazzi1/sys | |||
There was a problem hiding this comment.
I'd prefer the official repo vs. fork
| @@ -74,7 +75,9 @@ checkPaths config = do | |||
| fork :: Checker a b () -> Checker a b () | |||
| fork act = do | |||
| s0 <- get | |||
| void $ liftIO $ forkIO (curTGroup s0) $ evalChecker act s0 | |||
| void $ liftIO $ do | |||
| setNumCapabilities 1 -- number of Threads | |||
There was a problem hiding this comment.
I don't think we want this. Definitely not fixed to 1, but more generally you can control this from the cli with flags to ghc, no?
|
|
||
| # Getting Bitcode (LLVM) | ||
|
|
||
| You can use wllvm or gllvm to get Bitcode and Assembly Language Format Files (*.ll) |
There was a problem hiding this comment.
This is a nice add, I'd make it part of a separate PR. I have no idea what these are so links to them and how to use vs. say our dclang would be great.
|
This PR is to document my tests to fix the OOM issue. Added some changes to process files in 2 files batch (I think it works, new to Haskell) Want to see on which file, function it OOMs .... actually a cool feature would be to make a timeout in thread and when one file takes too long, it could be skipped. This can be totally wrong, as my other ideas. Just playing with it around. |
|
Kind of solved with a script that restarts job after it was OOMed ... it knows where to start since processed files were renamed to (*.ll.done). Will see how it works ... |
|
@marcinguy it's awesome that you're playing with Sys! Keep it up! But please be mindful that we get emails and notifications about issues, PRs, and even every push and comment to a PR. So let's keep PRs to pull requests (where e.g. we review the code/docs to an issues) please. |
Added UAF Check info to Readme.MD and Threads and LLVM Bitcode info.