Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing an indexing error in MSP #139

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fixing an indexing error in MSP #139

merged 1 commit into from
Mar 20, 2024

Conversation

jmlarson1
Copy link
Collaborator

Because nf is index of the last-evaluated point, it is one less than the number of evaluated points.

We can evaluate at most nfmax - nf - 1 when updating models.

@coveralls
Copy link

coveralls commented Mar 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8347113967

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 97.436%
Totals Coverage Status
Change from base Build 8331393499: 0.6%
Covered Lines: 38
Relevant Lines: 39
💛 - Coveralls

@jmlarson1 jmlarson1 merged commit d3f2e12 into develop Mar 20, 2024
23 checks passed
@jmlarson1 jmlarson1 deleted the indexing_error branch March 25, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenickelly mmenickelly mmenickelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmlarson1 @coveralls @mmenickelly