Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GetKinematicSolverInfo #35

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Feb 14, 2018

GetKinematicSolverInfo.srv has been removed from moveit_msgs by moveit/moveit_msgs#3,
since I'm not sure what is the best way to re-write code without this service, but to write the list of joint names directory

GetKinematicSolverInfo.srv has been removed from moveit_msgs by moveit/moveit_msgs#3,
since I'm not sure what is the best way to re-write code without this service, but to write the list of joint names directory
@k-okada k-okada merged commit 2f14420 into PR2:kinetic-devel Feb 14, 2018
@v4hn
Copy link
Member

v4hn commented Feb 14, 2018

The previous code already listed the joints more or less hard-coded:

https://github.com/k-okada/pr2_apps/blob/e4dc55d7c450910e884207e8a177553dbf0ba7ff/pr2_teleop_general/src/pr2_teleop_general_commander.cpp#L669

So I don't think it is particularly bad to hard-code them in your place too.
Of course it would be better to do this just once in a global vector...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants