Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GetKinematicSolverInfo.srv #3

Closed
isucan opened this issue Feb 8, 2013 · 5 comments
Closed

remove GetKinematicSolverInfo.srv #3

isucan opened this issue Feb 8, 2013 · 5 comments
Assignees

Comments

@isucan
Copy link
Contributor

isucan commented Feb 8, 2013

It is only used by pr2_arm_kinematics and nobody calls it. With the new plugin API for kinematics, this is not needed and causes confusion.

@130s
Copy link
Contributor

130s commented Nov 17, 2016

Addressed for Kinetic in #35

@130s 130s closed this as completed Nov 17, 2016
@130s
Copy link
Contributor

130s commented Nov 17, 2016

Addressed for Kinetic in #35

That's only for ROS Kinetic onward, so reopening.

@130s 130s reopened this Nov 17, 2016
@davetcoleman
Copy link
Member

No, I don't think we should backport a change like this to LTS indigo, or even jade. This issue has been addressed and can be closed.

k-okada added a commit to k-okada/pr2_apps that referenced this issue Feb 14, 2018
GetKinematicSolverInfo.srv has been removed from moveit_msgs by moveit/moveit_msgs#3,
since I'm not sure what is the best way to re-write code without this service, but to write the list of joint names directory
@k-okada
Copy link

k-okada commented Feb 14, 2018

we could not compile pr2_apps on kinetic due to this change, so how can we rewrite the code without using GetKinematicSolverInfo
see PR2/pr2_apps#35

@v4hn
Copy link
Contributor

v4hn commented Feb 14, 2018

@k-okada The most convenient way to get the same list of joints is probably

moveit::planning_interface::MoveGroupInterface left("left_arm");
std::vector<std::string> joint_names= left.getActiveJoints();

Maybe you want to use getJointNames() instead.
I'm not sure whether the old service listed passive/mimic joints or not.
For the specific use-case on the PR2's arm groups this shouldn't matter though.

henningkayser pushed a commit that referenced this issue Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants