forked from mayacakmak/pr2_pbd
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landmark registration algorithm is wrong #21
Comments
sonyaa has a correct implementation. |
This existed in the system previously, and was not introduced by me, correct? |
yes correct! sonyaa fixed it to do the RSS experiments but it's in her fork. |
Can we assign @sonyaa to implement this? :-) |
This is not urgent, it's the bug we've had for the longest time so I know exactly what not to do during demos. But I put it in so we remember to fix it at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When there are two similar objects in the learned action, sometimes they end up being registered to the same object during execution. This can be avoided by implementing the registration algorithm as described in the RSS paper.
The text was updated successfully, but these errors were encountered: