Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kiss_icp_dump_config executable #345

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

benemer
Copy link
Member

@benemer benemer commented Jun 4, 2024

The function called with the kiss_icp_dump_config executable does not exist, I changed it to the correct write_config function.

Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use this function? 🤔 I forgot we had it there

@benemer
Copy link
Member Author

benemer commented Jun 4, 2024

The write_dump_config does not exist; the write_config is used by the pipeline to save the config after the run. The executable we added also uses this function to dump a default config as a template if you want to modify some parameters.

@nachovizzo nachovizzo merged commit 6d76ca8 into main Jun 11, 2024
17 checks passed
@nachovizzo nachovizzo deleted the benedikt/fix_dump_config branch June 11, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants