Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataloader bug fixes and optimization for kiss icp #45

Merged
merged 13 commits into from
Jan 23, 2023
Merged

dataloader bug fixes and optimization for kiss icp #45

merged 13 commits into from
Jan 23, 2023

Conversation

sumanthrao1997
Copy link
Contributor

No description provided.

@nachovizzo
Copy link
Collaborator

Amazing! Thanks a lot for your contribution. And I didn't know that the DL had a bug! Thanks for spotting this.

If it's not too much to ask, here are some tasks I'd like to solve before merging this

  • black . # format the code
  • Add a method self.apply_calibration that brings the poses estimated by KISS-ICP to the same coordinate frame of the GT poses
  • Remove the pcd.transfrom
  • [ ]

@nachovizzo nachovizzo changed the base branch from nacho/add_tum_dataloader to main January 23, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants