Ms2/deployment view #337
Merged
Ms2/deployment view #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
FelipeTrost
requested changes
Jul 26, 2024
There was a problem hiding this comment.
You should also check the ability, but you can do it in a future PR
src/management-system-v2/app/(dashboard)/[environmentId]/executions/page.tsx
Outdated
Show resolved
Hide resolved
| return 0; | ||
| }); | ||
|
|
||
| const openFolder = async (id: string) => { |
There was a problem hiding this comment.
You should give feedback if something goes wrong, maybe do it in a sepparate PR after #340
src/management-system-v2/app/(dashboard)/[environmentId]/executions/deployments-modal.tsx
Outdated
Show resolved
Hide resolved
| <> | ||
| <ElementList | ||
| data={processes} | ||
| columns={breakpoint.xl ? selectedColumns : mobileColumns} |
There was a problem hiding this comment.
There is no need to do this, the responsive key on each column can blend that column out, you could just use one big column list.
...ment-system-v2/app/(dashboard)/[environmentId]/executions/deployment-selection-icon-view.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/app/(dashboard)/[environmentId]/engines/engines-modal.tsx
Outdated
Show resolved
Hide resolved
src/management-system-v2/app/(dashboard)/[environmentId]/engines/page.tsx
Outdated
Show resolved
Hide resolved
| pagination: { pageSize: 10, position: ['bottomCenter'] }, | ||
| }} | ||
| data={engines} | ||
| columns={breakpoint.xl ? selectedColumns : mobileColumns} |
There was a problem hiding this comment.
There is no need to have to separate lists, you can just set the responsive property on each column accordingly.
|
✅ Successfully created Preview Deployment. |
FelipeTrost
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added view for deployments and engines
Details