Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt (jinja) integration been removed from prql-compiler? #2104

Closed
2 tasks done
eitsupi opened this issue Mar 11, 2023 · 2 comments
Closed
2 tasks done

dbt (jinja) integration been removed from prql-compiler? #2104

eitsupi opened this issue Mar 11, 2023 · 2 comments
Assignees
@max-sixty
Labels
documentation

Comments

@eitsupi
Copy link
Member

eitsupi commented Mar 11, 2023 •
edited
Loading

What happened?

The functionality that was in prql-compiler for dbt integration seems to have been removed in #1722 (moved to prqlc).

prql/book/src/integrations/dbt.md

Lines 156 to 158 in ed1e896

- The PRQL compiler passes text that's containing `{{` & `}}` through to dbt
without modification, which allows us to embed Jinja expressions in PRQL.
(This was added to PRQL specifically for this use-case.)

Perhaps the documentation needs updating?
And it might be better to put it on Changelog as a breaking change.

PRQL input

from {{ ref('foo') }}

SQL output

None

Expected SQL output

No response

MVCE confirmation

  • Minimal example
  • New issue

Anything else?

No response
@eitsupi eitsupi added bug Invalid compiler output or panic compiler labels Mar 11, 2023
@eitsupi eitsupi changed the title dbt integration been removed from prql-compiler? dbt (jinja) integration been removed from prql-compiler? Mar 11, 2023
@max-sixty
Copy link
Member

Yes; we never actually ended up using this — I couldn't get dbt to run things in the order that I wanted. (And now there are discussions about a deeper integration with dbt).

So yes we should remove these docs. I can do that unless anyone gets there first...

Yes we can add to the changelog too, no harm in doing that.

@max-sixty max-sixty self-assigned this Mar 17, 2023
@max-sixty max-sixty added documentation and removed bug Invalid compiler output or panic compiler labels Mar 17, 2023
@eitsupi eitsupi mentioned this issue Apr 2, 2023
Merged
eitsupi added a commit that referenced this issue Apr 2, 2023
@eitsupi @pre-commit-ci
docs(changelog): fix typo and tweak some items related to breaking ch…
ca23ad9 
…age of 0.6.0 (#2366)

Related to #2104

A set of some minor fixes that I noticed when I looked at the Changelog
that is now included in the Book.

- Fix some typos.
- Added some info on some of breaking changes
  - Pass through jinja template (`{{` and `}}`).
  - `switch` -> `case`

I tried to include the admonish note about the change of name from
`switch` to `case` in the changelog, but it didn't work (bug?).
So I add it to the `case` page.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
prql-bot pushed a commit that referenced this issue Apr 2, 2023
@eitsupi @github-actions
docs(changelog): fix typo and tweak some items related to breaking ch…
79e9dea 
…age of 0.6.0 (#2366)

Related to #2104

A set of some minor fixes that I noticed when I looked at the Changelog
that is now included in the Book.

- Fix some typos.
- Added some info on some of breaking changes
  - Pass through jinja template (`{{` and `}}`).
  - `switch` -> `case`

I tried to include the admonish note about the change of name from
`switch` to `case` in the changelog, but it didn't work (bug?).
So I add it to the `case` page.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit ca23ad9)
@eitsupi eitsupi mentioned this issue May 17, 2023
Merged
@eitsupi
Copy link
Member Author

eitsupi commented Jun 15, 2023

Closes because the document has been updated.

@eitsupi eitsupi closed this as completed Jun 15, 2023
@eitsupi eitsupi mentioned this issue May 26, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-sixty max-sixty

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@max-sixty @eitsupi